common: add hasOwnProperty to for...in loop. Fixes #1984. #1990
Conversation
This is to stop the for...in loop from looping over properties that aren't actually part of the object, which can lead to the call stack overflowing under certain circumstances.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
googlebot
added
the
cla: no
|
I signed it! |
|
CLAs look good, thanks! |
googlebot
added
cla: yes
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
googlebot
added
cla: no
packages/common/src/util.js
Outdated
| @@ -518,7 +518,9 @@ function replaceProjectIdToken(value, projectId) { | |||
|
|
|||
| if (is.object(value)) { | |||
| for (var opt in value) { | |||
| value[opt] = replaceProjectIdToken(value[opt], projectId); | |||
| if (value.hasOwnProperty(value)) { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Thank you! |
This is to stop the for...in loop from looping over properties that
aren't actually part of the object, which can lead to the call stack
overflowing under certain circumstances.